Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle abvm/blwm for indic scripts when generating mark features #1086

Open
anthrotype opened this issue Nov 1, 2024 · 0 comments
Open

handle abvm/blwm for indic scripts when generating mark features #1086

anthrotype opened this issue Nov 1, 2024 · 0 comments
Labels
correctness enhancement New feature or request

Comments

@anthrotype
Copy link
Member

For some "indic" scripts, ufo2ft markFeatureWriters generates abvm (above mark) and blwm (below mark) features instead of mark.

The list of scripts is here:
https://github.com/googlefonts/ufo2ft/blob/d15ef8f6f235804733c6e2ea5f01f39aafb92f45/Lib/ufo2ft/featureWriters/markFeatureWriter.py#L337

To decide whether an anchor should go to abvm or blmw there's a hard-coded list of anchor names that are assigned "below" status, the rest are assumed to be "above", see:
https://github.com/googlefonts/ufo2ft/blob/d15ef8f6f235804733c6e2ea5f01f39aafb92f45/Lib/ufo2ft/featureWriters/markFeatureWriter.py#L948-L961

This is similar to #753, where the kernFeatureWriters choose the 'dist' tag instead of 'kern' for some Indic scripts.

One affected project that I stumbled upon is https://github.com/notofonts/takri
But I expect all projects containing one of the indic scripts to be also affected.

@anthrotype anthrotype added correctness enhancement New feature or request labels Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correctness enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant