Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to use CC's seems to cause the changes in the commit to be ignored when generating releases #1042

Open
wesleytodd opened this issue Oct 8, 2024 · 1 comment
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@wesleytodd
Copy link

wesleytodd commented Oct 8, 2024

Environment details

  • Programming language: JS
  • OS: n/a
  • Language runtime version: n/a
  • Package version: n/a

Steps to reproduce

Commits not following CCs have now twice not generated releases for us while ones which do work as expected. In the logs we see the following:

Building candidate release pull request for path: packages/turbo-task
❯ type: node
❯ targetBranch: main
❯ commit could not be parsed: 9dd27740f2cc17b6467f3327aaa09dec1296131f add support for newt vars and remove log order grouping (#225)
❯ commits: 0
✔ Considering: 0 commits
✔ No commits for path: packages/turbo-task, skipping

Despite that commit having changes to two applicable packages:

$git --no-pager show --name-only 9dd27740f2cc17b6467f3327aaa09dec1296131f
commit 9dd27740f2cc17b6467f3327aaa09dec1296131f (main)
Author: <redacted>
Date:   Mon Oct 7 16:11:31 2024 -0700

    add support for newt vars and remove log order grouping (#225)

packages/turbo-task/lib/task.js
plugins/plugin-turbo/turbo-json.js
@wesleytodd wesleytodd added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 8, 2024
@wesleytodd
Copy link
Author

It is possible this is miss-attributed to the commit format and that log. We found another case where it was happening with the chore: prefix. May need some more debugging to see why this commit (and a few others) are not being correctly detected while others are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants