Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Potentially add a unit test to verify the functionality of parameter auth_local_webserver #53

Closed
parthea opened this issue Jun 7, 2017 · 1 comment
Labels
type: process A process-related concern. May include testing, release, or the like.

Comments

@parthea
Copy link
Contributor

parthea commented Jun 7, 2017

It may be possible to add a unit test to verify the functionality of parameter auth_local_webserver of read_gbq() and to_gbq() in #39 in order to improve testing. One potential solution is to capture the output in the unit test and look for specific text :

'Go to the following link in your browser:' , when auth_local_webserver=False
or
'Your browser has been opened to visit:' , when auth_local_webserver=True

@jreback jreback added the type: process A process-related concern. May include testing, release, or the like. label Jun 9, 2017
@tswast
Copy link
Collaborator

tswast commented Jan 25, 2019

This parameter is now passed on through to pydata-google-auth. I've filed this as pydata/pydata-google-auth#9 over there.

@tswast tswast closed this as completed Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

3 participants