Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pypi source distribution name changed dashes to underscores with 2.137.0 #2437

Open
akrherz opened this issue Jul 14, 2024 · 2 comments
Open
Assignees
Labels
external This issue is blocked on a bug with the actual product. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@akrherz
Copy link

akrherz commented Jul 14, 2024

I apologize if this something that changed with pypi, but I'm noticing that the source distribution name on pypi changed

Release Filename
2.136.0 google-api-python-client-2.136.0.tar.gz
2.137.0 google_api_python_client-2.137.0.tar.gz
@parthea
Copy link
Contributor

parthea commented Jul 15, 2024

In https://github.com/googleapis/google-api-python-client/pull/2430/files, we updated the dependencies of packages used in the release script.

setuptools 69.2.0 -> setuptools 70.2.0
twine 4.0.2 -> twine 5.1.1

It's likely related to the upgrade in #2430. There was likely a change upstream in twine or setuptools. We expect to see dashes, rather than underscores as that is what we have in setup.py

name="google-api-python-client",

@parthea parthea added type: question Request for information or clarification. Not an issue. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. external This issue is blocked on a bug with the actual product. and removed type: question Request for information or clarification. Not an issue. labels Jul 15, 2024
@akrherz
Copy link
Author

akrherz commented Jul 25, 2024

2.138.0 used underscores as well, I am fine with closing this if this is how it will remain going forward :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external This issue is blocked on a bug with the actual product. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants