Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor 🎨: crawler/app services #194

Merged
merged 5 commits into from
Jun 16, 2023
Merged

refactor 🎨: crawler/app services #194

merged 5 commits into from
Jun 16, 2023

Conversation

peb-peb
Copy link
Contributor

@peb-peb peb-peb commented Jun 12, 2023 •
edited
Loading

Notes

closes #192
ref to #153

  1. fix absolute imports from gcp_scanner. ... to src.gcp_scanner. ...
  2. refactored the if statements to service_crawler_map.

@mxmssh @0xDeva

@mshudrak
Copy link
Collaborator

Overall looks good but could you please add tests similar to what @sudiptob2 implemented here: https://github.com/google/gcp_scanner/pull/189/files#diff-5a1381911ce36e5147cd366966086d0d5d1ac1118e75a2458c0e5568750e8ff2R772
and here https://github.com/google/gcp_scanner/pull/189/files#diff-5a1381911ce36e5147cd366966086d0d5d1ac1118e75a2458c0e5568750e8ff2R328

@mshudrak mshudrak self-requested a review June 12, 2023 21:36
mshudrak
mshudrak requested changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@mshudrak mshudrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically we need to answer sudipto comment above on memory impact of using dict and add tests as here: could you please add tests similar to what @sudiptob2 implemented here: https://github.com/google/gcp_scanner/pull/189/files#diff-5a1381911ce36e5147cd366966086d0d5d1ac1118e75a2458c0e5568750e8ff2R772
and here https://github.com/google/gcp_scanner/pull/189/files#diff-5a1381911ce36e5147cd366966086d0d5d1ac1118e75a2458c0e5568750e8ff2R328

@mshudrak mshudrak merged commit a5eaf21 into google:main Jun 16, 2023
@peb-peb peb-peb deleted the crawler/app_services branch June 16, 2023 22:11
@peb-peb peb-peb mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudiptob2 sudiptob2 sudiptob2 left review comments

@mshudrak mshudrak mshudrak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subtasks: Implement crawl factory for App Resources.
3 participants
@peb-peb @mshudrak @sudiptob2