Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: add support for additional GCP resources. #247

Open
3 of 11 tasks
sudiptob2 opened this issue Jul 17, 2023 · 4 comments
Open
3 of 11 tasks

Epic: add support for additional GCP resources. #247

sudiptob2 opened this issue Jul 17, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@sudiptob2
Copy link
Contributor

sudiptob2 commented Jul 17, 2023

📝 List of resources:

I've compiled the following resources that we need to add support for. Feel free to suggest any other resources that should be prioritized. Additionally, let me know if there's anything else we should include in the list.

🛠️ Implementation Steps:

Here's a brief description of how to implement new resource crawling:

Step 1:

Browse through the google-api-python-client library to find the suitable client and determine the data to crawl.

Step 2:

If the client isn't already implemented in the client package, create a client factory.

Step 3:

For your crawler, establish a new crawler factory in the crawler package.

Step 4:

In the scanner.py file, include the crawler in the crawl loop and update the crawl_client_map. Don't forget to modify the example.config to account for the new crawler.

Step 5:

Ensure proper unit tests are in place. If applicable, add acceptance tests (If you are a team member who has access to the test_gcp_project in the Google Cloud Platform)

📝 Note: Please bear in mind that the code is undergoing significant refactoring, so the above-mentioned process might change.

@Mac16661
Copy link

Mac16661 commented Oct 1, 2023

Hey @sudiptob2 I am complete beginner to open source contribution. Can I work on these issues ?

@mshudrak
Copy link
Collaborator

mshudrak commented Oct 4, 2023

Hey @Mac16661, we do not assign bugs. If you feel like you want to contribute, you can just submit PR fixing one of the problems.

@shravankshenoy
Copy link
Contributor

Hi everyone, I have raised a PR to add support to CloudAsset resource. PR: #305. Please let me know if any changes are required.

@aryanagrawal22
Copy link
Contributor

Hi Guys, I have raised a PR adding the support to Cloud Trace resource. Let me know in any case of changes ✌️
PR: #307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants