Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subtask: Implement client factory for DNS client. #155

Closed
Tracked by #153
sudiptob2 opened this issue May 23, 2023 · 0 comments · Fixed by #156
Closed
Tracked by #153

Subtask: Implement client factory for DNS client. #155

sudiptob2 opened this issue May 23, 2023 · 0 comments · Fixed by #156
Labels
enhancement New feature or request

Comments

@sudiptob2
Copy link
Contributor

Subtask of epic #153
@sudiptob2 sudiptob2 added the enhancement New feature or request label May 23, 2023
@sudiptob2 sudiptob2 mentioned this issue May 23, 2023
Open
39 tasks
sudiptob2 added a commit to sudiptob2/gcp_scanner that referenced this issue May 23, 2023
@sudiptob2
fix:sparkles:: implement client factory for DNS client [google#155]
a503910 
Signed-off-by: Sudipto Baral <[email protected]>
@sudiptob2 sudiptob2 mentioned this issue May 23, 2023
Merged
@sudiptob2 sudiptob2 changed the title Implement client factory for DNS client. Subtask: Implement client factory for DNS client. May 28, 2023
under-hill pushed a commit that referenced this issue May 30, 2023
@sudiptob2
refactor 🔨 : implement client factory for DNS client [#155] (#156)
fce767f 
* fix:sparkles:: implement client factory for DNS client [#155]

Signed-off-by: Sudipto Baral <[email protected]>

* refactor:hammer:: refactor list_dns_policies

Signed-off-by: Sudipto Baral <[email protected]>

* refactor:hammer:: refactor managed_zones

Signed-off-by: Sudipto Baral <[email protected]>

* refactor:hammer:: update docstring for Clientfactory class

Signed-off-by: Sudipto Baral <[email protected]>

* refactor:hammer:: update docstring for DNSClient

Signed-off-by: Sudipto Baral <[email protected]>

* refactor:hammer:: fix spelling.

Signed-off-by: Sudipto Baral <[email protected]>

* refactor:hammer:: fix spelling in docstring.

Signed-off-by: Sudipto Baral <[email protected]>

* feat: update docstring.

Signed-off-by: Sudipto Baral <[email protected]>

* refactor:hammer:: fix docstring for IClient interface.

* refactor:hammer:: fix docstring.

* test:rotating_light:: add unit test for client factory.

---------

Signed-off-by: Sudipto Baral <[email protected]>
sudiptob2 added a commit to sudiptob2/gcp_scanner that referenced this issue May 31, 2023
@sudiptob2
fix:sparkles:: implement client factory for DNS client [google#155]
16ef0f1 
Signed-off-by: Sudipto Baral <[email protected]>
under-hill pushed a commit that referenced this issue May 31, 2023
@sudiptob2
refactor hammer : implement client factory for Compute client (#159)
90c4569 
* fix:sparkles:: implement client factory for DNS client [#155]

Signed-off-by: Sudipto Baral <[email protected]>

* refactor:hammer::implement compute client factory.

* refactor:hammer::update unit test for crawl functions related to compute resource.

* refactor:hammer::fix linting errors.

* test:rotating_light:: add unit test compute client factory.

* nit: :art: : fix broken formatting.

* fix: :bug: : fix missing comma.

---------

Signed-off-by: Sudipto Baral <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor 🔨 : implement client factory for DNS client [#155] sudiptob2/gcp_scanner
1 participant
@sudiptob2