Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I wrote the cilf file and cpp file, but I can't import this file #86

Open
one-matrix opened this issue Dec 20, 2023 · 4 comments
Open

Comments

@one-matrix
Copy link

I wrote the cilf file and cpp file, but I can't import this file,
do I need to compile it?, how to link python and C++?

image

from third_party.nucleus.io.python import tfrecord_reader ImportError: cannot import name 'tfrecord_reader' from 'third_party.nucleus.io.python'

@rwgk
Copy link
Contributor

rwgk commented Dec 20, 2023

@pichuan does nucleus have support for building user-provided .clif extensions?

@pichuan
Copy link

pichuan commented Dec 20, 2023

Thanks @rwgk for tagging me!

The Nucleus BUILD file for clif is here: https://github.com/google/nucleus/blob/v0.6.0/nucleus/util/python/BUILD

@one-matrix , if you're able to build Nucleus (or DeepVariant repo) before any changes, then, after you add your new files, and your own corresponding BUILD rules, you can try to build again.

Also note that the latest released Nucleus code is in https://github.com/google/deepvariant/tree/r1.6/third_party/nucleus . We used to make standalone Nucleus releases, but in recent years we focused more on making it as part of DeepVariant.

@one-matrix
Copy link
Author

one-matrix commented Dec 21, 2023

@pichuan thanks,but how can i compile the clif file? and What kind of extra files will generate if i compile the clif,There are very few document about clif. the error show that i cannot import the tfrecord_reader,But the path and file exist.

@pichuan
Copy link

pichuan commented Dec 21, 2023

Hi @one-matrix ,
please take a look at google/deepvariant#756 (comment) . Hope that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants