Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix importing patch_decoder" #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

w-e-w
Copy link

@w-e-w w-e-w commented May 21, 2024

I'm pretty sure that "fix" actually broke this repo as a module

I belive the error ImportError: attempted relative import with no known parent package occurs if people try to run src/timesfm.py directly
and they might have reason to do so because this reop did not work as a module on it's initial release

adding to this this repo is structured weirdly
so people might be confused on how they should be using this repo and running the code

  • shoud they be cloneing this in ther peoject as a module
  • should they colne this project and add they own code into src/
  • should they clone this as take parts of the code into the own project

timeline

  • before fix code structure 24bd19c this repo only works under several conditions so people migh comewith diffrent creative ways ways of running the code
  • after the commit fix code structure 24bd19c made this reop worked as a module but breaks running itdirectly
  • then Fix importing patch_decoder #32 makes src/timesfm.py + src/patched_decoder.py as standload code but breaks this a module

  • I sugest mergeing this PR reverting Fix importing patch_decoder #32 to make it function as a module for now
  • and in the future restructure the project completely to a more typical structure like
├── README.md
├── timesfm/            <---- package name
│   ├── __init__.py
│   ├── module.py
│   └── module.py
└── other stuff/
    ├── generate_awesomeness.py
    └── decrease_world_suck.py


the reason I don't perform the restructure myself in this PR is because a the restructure of the project would cause existing users to have issues, my intention is to only get back to a code working state

Copy link

google-cla bot commented May 21, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@w-e-w
Copy link
Author

w-e-w commented May 21, 2024

CLA...
just treat this as an issue post

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant