Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More efficient sanitization #408

Open
dometto opened this issue Jan 12, 2022 · 0 comments
Open

More efficient sanitization #408

dometto opened this issue Jan 12, 2022 · 0 comments

Comments

@dometto
Copy link
Member

dometto commented Jan 12, 2022

At the moment, we are calling sanitize(data) in the filter chain (at least) twice: in the actual Sanitize filter, and inside the Macro filter, to counter an exploit discovered a while ago by @yy0931 (see #402). We can try to make this more efficient by moving the Sanitize filter to earlier in the filter chain, so that it is executed after all the other steps. It's possible that this ends up breaking something for some users, if the Sanitize filter is overzealous and also removes some things we forgot to whitelist. But if the test suites pass, it's worth finding out I think. :)

We should also be sure to guard explicitly against the exploit, but I think the test included in #402 should suffice for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant