Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yuasa 屏障的图画得是不是有问题? #79

Open
cuglaiyp opened this issue Jun 25, 2021 · 1 comment
Open

Yuasa 屏障的图画得是不是有问题? #79

cuglaiyp opened this issue Jun 25, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@cuglaiyp
Copy link

cuglaiyp commented Jun 25, 2021

C.ref2 -> A,那么 shade(*slot)也就是shade(A),应该是把A着色为灰色,为什么图中是把A置为白色、C置为灰色了?

func YuasaWritePointer(slot *unsafe.Pointer, ptr unsafe.Pointer) {
    shade(*slot)
    *slot = ptr
}
  • 原文段落:8.2写屏障技术,图3:使用Yuasa写屏障赋值器

image

ps:还是同一个图,这个地方地方的文字和图不匹配,应该是YuasaWritePointer(C.ref3, B)吧
image

@changkun
Copy link
Member

changkun commented Jun 25, 2021

是的 这是一个已知错误 确实图是错的 PR welcome

@changkun changkun added the bug Something isn't working label Jun 25, 2021
@cuglaiyp cuglaiyp closed this as completed Jul 2, 2021
@changkun changkun reopened this Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants