Core: Convert Math class to namespace
#94441
Open
+672
−678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume this change qualifies as codestyle too? Or perhaps I'm missing something. |
|
Now that you mention it, yeah; this would technically qualify as that. Given that's already the case, might as well fixup stuff like argument name syntax |
Repiteo
force-pushed
the
core/math-namespace
branch
from
130c7f6
to
56158da
Compare
Repiteo
force-pushed
the
core/math-namespace
branch
from
56158da
to
e4a04f1
Compare
Repiteo
force-pushed
the
core/math-namespace
branch
from
e4a04f1
to
0bcc930
Compare
Repiteo
force-pushed
the
core/math-namespace
branch
from
0bcc930
to
0992117
Compare
Repiteo
force-pushed
the
core/math-namespace
branch
from
0992117
to
2b18a0e
Compare
fire
approved these changes
Oct 31, 2024
Repiteo
force-pushed
the
core/math-namespace
branch
2 times, most recently
from
a4070d2
to
05bcb88
Compare
Repiteo
force-pushed
the
core/math-namespace
branch
from
05bcb88
to
813171b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adopts the formatting seen in
godot-cppwhich opts forMathas a namespace rather than a class. Given the class already shouldn't be instanced, nor did it really utilize any class-specific functionality, functioning as a namespace feels more apt. Beyond the conversion, the only adjustments were:core/math/random_pcg.hinclude migrated tomath_funcs.cpp; explicitly included in the handful of files utilizingRandomPCGdirectly.default_rand, the one private field in the entire class, migrated tomath_funcs.cppas a static variable.RANDOM_32BIT_MAXreplaced by existing, equivalent define:UINT32_MAX.staticdeclaration removed from all functions.absd,absf,is_equal_approx, andis_zero_approxmoved up—a consequence of needing to be declared before use in a namespace context.math_funcs.{h|cpp}functions that weren't usingp_*argument syntax now do.Math::prefix removed in header where redundant.doublesorted beforefloatequivalent where applicable.