Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header does not provide information on what is expected from the object produced by GDExtension to be a valid Godot object #103

Open
VladoCC opened this issue Jul 11, 2022 · 1 comment

Comments

@VladoCC
Copy link

VladoCC commented Jul 11, 2022

It's unclear what this create function should return:

GDNativeExtensionClassCreateInstance create_instance_func; /* this one is mandatory */

But looking at the code in main godot repo, which handles this objects, it's obvious that there are specific requirement, including functions this object should have. Godot-cpp is complient with it as it appears.
Thus, to me it seems like it's important to cover this information in the header file. Be it a comment or (preferably) a struct.

@VladoCC
Copy link
Author

VladoCC commented Jul 11, 2022

I'd make a PR on it, if somebody can just give me description of this requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants