CMake: Alleviate target name clashes, visibility, and grouping. #1658
+45
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The thing GODOT_ENABLE_TESTING somewhat clashes with my PR #1650, I also guard |
Indeed it does clash, perhaps it needs its own PR, if either of our PR's get merged, the other can rebase and fix. I thought about splitting this into three parts, but I dont know how fine grained PR's should be. |
Torets
added a commit
to Torets/godot-cpp-optional-targetss
that referenced
this pull request
Nov 27, 2024
|
I've reverted my changes for now. yours seem to better in terms of naming, description of PR and placement of option. |
enetheru
force-pushed
the
name_clash
branch
2 times, most recently
from
e2e79f8
to
9d74b0e
Compare
Simplify <platform>_generate cmake function signature, as TARGET_ALIAS and TARGET_NAME are still in scope and do not need to be passed. Add USE_FOLDERS, and FOLDER properties to group targets in VS and XCode Guard test target with GODOT_ENABLE_TESTING
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves CMake name clashes #1657, Partially resolves optionally disable targets #1650, and tidies IDE usage for VS and XCode by grouping targets under a subfolder.
GODOT_ENABLE_TESTINGoption default OFF, and guardadd_subdirectory( test )by defaultUSE_FOLDERS ONand target propertyFOLDER "godot-cpp"to group targets in VS and XCode