CMake: Enable using clang-cl on windows #1651
Draft
+101
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
reviewed
Nov 25, 2024
dsnopek
approved these changes
Nov 25, 2024
|
I've also fixed the commit message like asked. |
This was referenced Nov 26, 2024
|
This one will need a rebase - there's a conflict after having merged a few of your other PRs |
When downloading clang from llvm.org the compiler defaults to clang-cl with the msvc compiler interface. This commit detects that scenario and sets the helper variables to account for it. Cleans up the other duplicated helper variables that are still in scope. And fixes formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As listed here: #1250
clang-cl on windows installed from official llvm website fails because it emulates the msvc interface.
Prior solution assumed that because compiler is clang it uses gnu interface.
CMake offers some helper variables to account for this simulation/emulation of other compilers like:
CMAKE_CXX_COMPILER_FRONTEND_VARIANT
This PR detects the difference and sets the helper variables to match what is in use.
It isn't robust enough to mix and match compiler and linker interfaces though, so using a gnu style linker with an msvc style compiler will fail.
I've tested this on windows and mac, with windows based compilers msvc, msys-gcc msys-clang, llvm, mingw64, without issue.
Fixes #1250