Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Attempt to better handle hook disposal #1803

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Attempt to better handle hook disposal #1803

wants to merge 1 commit into from
+67 −21

Conversation

KazWolfe
Copy link
Member

@KazWolfe KazWolfe commented May 5, 2024

  • Use a Weak Concurrent Collection to track scoped hooks
  • Make Hooks remove themselves from the Tracked Hook list.

@KazWolfe KazWolfe requested a review from a team as a code owner May 5, 2024 23:22
@KazWolfe
fix: Attempt to better handle hook disposal
427933b 
- Use a Weak Concurrent Collection to track scoped hooks
- Make `Hook`s remove themselves from the Tracked Hook list.
@KazWolfe KazWolfe added enhancement New feature or request core Dalamud core plugin-api About or affects the Plugin API bug Something isn't working and removed enhancement New feature or request labels Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@goaaats goaaats

Labels
bug Something isn't working core Dalamud core plugin-api About or affects the Plugin API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KazWolfe @goaaats