Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add missing XivChatTypeInfo to XivChatType #1366

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

rreminy
Copy link
Contributor

@rreminy rreminy commented Aug 31, 2023

I noticed some XivChatType doesn't have an associated [XivChatTypeInfo] attribute, therefore this PR aims in adding those missing attributes.

This PR currently contain placeholders and therefore its not ready for merge. I currently do not know the exact default hex colors of the channels and whether the slugs would be okay/correct.

I noticed some `XivChatType` doesn't have an associated `[XivChatTypeInfo]` attribute, therefore this PR aims in adding those missing attributes.

This PR currently contain placeholders and therefore its not ready for merge. I currently do not know the exact default hex colors of the channels and whether the slugs would be okay/correct.
@MidoriKami
Copy link
Contributor

If you make TellOutgoing be "Tell (Outgoing)" then TellIncoming needs to be adjusted to "Tell (Incoming)"

DailyDuty, and most likely other plugins iterate over the enum and get the attribute if it exists, and if it doesn't exist just .tostring the enum name.

@rreminy
Copy link
Contributor Author

rreminy commented Aug 31, 2023

If you make TellOutgoing be "Tell (Outgoing)" then TellIncoming needs to be adjusted to "Tell (Incoming)"

Agreed, this is also a bit of why I added a comment at the end as I'm not sure how we'll handle this.

DailyDuty, and most likely other plugins iterate over the enum and get the attribute if it exists, and if it doesn't exist just .tostring the enum name.

I guess I'll do the same workaround as well.

@rreminy
Copy link
Contributor Author

rreminy commented Sep 3, 2023

Currently missing colors for:

  • Debug
  • NPC Dialogue (Is it the same as NPC Dialogue Announcements?)
  • Retainer Sale

@rreminy
Copy link
Contributor Author

rreminy commented Sep 4, 2023

I'll need help with the colors, the values we used are not the same as the values I'm getting through the color picker, I don't know how we're getting the values.

I finished getting all the colors but I'd like to make sure they're correct.

@KazWolfe
Copy link
Member

KazWolfe commented Jun 3, 2024

Is this PR still desired/in progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants