-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add missing XivChatTypeInfo to XivChatType #1366
base: master
Are you sure you want to change the base?
Conversation
I noticed some `XivChatType` doesn't have an associated `[XivChatTypeInfo]` attribute, therefore this PR aims in adding those missing attributes. This PR currently contain placeholders and therefore its not ready for merge. I currently do not know the exact default hex colors of the channels and whether the slugs would be okay/correct.
If you make DailyDuty, and most likely other plugins iterate over the enum and get the attribute if it exists, and if it doesn't exist just .tostring the enum name. |
Agreed, this is also a bit of why I added a comment at the end as I'm not sure how we'll handle this.
I guess I'll do the same workaround as well. |
Currently missing colors for:
|
I'll need help with the colors, the values we used are not the same as the values I'm getting through the color picker, I don't know how we're getting the values. I finished getting all the colors but I'd like to make sure they're correct. |
Is this PR still desired/in progress? |
I noticed some
XivChatType
doesn't have an associated[XivChatTypeInfo]
attribute, therefore this PR aims in adding those missing attributes.This PR currently contain placeholders and therefore its not ready for merge. I currently do not know the exact default hex colors of the channels and whether the slugs would be okay/correct.