-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor markup render system #32612
base: main
Are you sure you want to change the base?
Conversation
e337c5f
to
adf30d8
Compare
2791c06
to
052867a
Compare
052867a
to
1651ea4
Compare
40ec58c
to
9c198a3
Compare
9c198a3
to
b4a1e7e
Compare
Move the render under |
There are enough comments, that's the only choice due to the legacy problematic code structure. Otherwise there will be much more unnecessary changes in this PR. |
ecd3673
to
312fc2b
Compare
This PR removes (almost) all path tricks, and introduces "renderhelper" package.
Now we can clearly see the rendering behaviors for comment/file/wiki, more details are in "renderhelper" tests.
Fix #31411 , fix #18592, fix #25632 and maybe more problems. (ps: fix #32608 by the way)