Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extractor improvements #22

Open
6 tasks
moul opened this issue Oct 2, 2024 · 1 comment
Open
6 tasks

extractor improvements #22

moul opened this issue Oct 2, 2024 · 1 comment

Comments

@moul
Copy link
Member

moul commented Oct 2, 2024

  • The system needs to create, update, and delete items. In other words, the folder's output should exactly match the chain state. Then, git will handle the history and related tasks.
  • We should find a way to avoid using :BLOCKNUMBER in the folder names. Can someone propose a solution?
  • The job should be standalone and open a PR. Ideally, it should have a fixed branch name that is reused each time the CI runs. This way, we can choose to merge or wait.
  • The script must be runnable locally.
  • The extractor can create a new file with metadata in each folder, such as extractor.json. This file will contain transaction information, including the .jsonl filepath and line number, so we can easily understand what we are looking at.
  • Bonus: One commit per addpkg, with transaction details in the commit message. Edit: I believe it's better to only have the extractor.json file.

With these improvements, the goal is to simulate a history patch locally (manual JSONL patching), run the extractor locally, and have a way to check the impact of changes, such as disappearing contracts, patched contracts, new contracts, etc.

@Kouteki
Copy link

Kouteki commented Nov 19, 2024

Related #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants