Make all extends use placeholders #1649
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marri
reviewed
Jun 23, 2022
Marri
reviewed
Jun 23, 2022
| @@ -126,7 +126,7 @@ | |||
|
|
|||
| /* The preview icon boxes on replace icon and replace character */ | |||
| .replace-icon { | |||
| @extend .icons-box; | |||
| background-color: $bg_color_icon; | |||
There was a problem hiding this comment.
Was this on purpose? Doesn't seem related to the @extend at least.
There was a problem hiding this comment.
I'd have to hunt for the icons-box definition but I suspect I just copied that from it
teceler
force-pushed
the
css/placeholders
branch
from
858864b
to
28780d3
Compare
scss/at-extend-no-missing-placeholder
teceler
force-pushed
the
css/placeholders
branch
from
28780d3
to
7d0789c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1633, probably needs tested for styling consistency