Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double negatives #779

Open
glacials opened this issue Aug 12, 2021 · 0 comments
Open

Double negatives #779

glacials opened this issue Aug 12, 2021 · 0 comments
Labels
bug Issues that are solved by repairing functionality good first issue Issues that don't need a ton of context to address small Issues that probably won't take much work to address

Comments

@glacials
Copy link
Owner

Open this run: https://splits.io/861p

And hover over the second-to-last split in the timeline:

image

Looks like format_casual may have never worked for negatives and we just never noticed, because we tend to use pretty_difference for negative use cases.

This is two issues:

  • When format_casual displays a negative number, it shows two - characters instead of one
  • The possible timesave for this segment is negative which doesn't make sense. If it's us then this is a bug to be fixed, if this is a corrupted split file then we should at least hide the number instead of rendering one that doesn't make sense. Hopefully also find out how a file could get corrupted like this through normal use.
@glacials glacials added bug Issues that are solved by repairing functionality small Issues that probably won't take much work to address good first issue Issues that don't need a ton of context to address labels Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that are solved by repairing functionality good first issue Issues that don't need a ton of context to address small Issues that probably won't take much work to address
Projects
None yet
Development

No branches or pull requests

1 participant