Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] move getToken api to separate group #20391

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Nov 27, 2024

Description

[server] move getToken api to separate group

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@geropl
Copy link
Member

geropl commented Nov 27, 2024

@iQQBot Not sure I got this right: Are we using the old ws API? Or the gRPC-based, and would need a change here? Anyway, I think it would be great to keep both in sync if not too much effort.

@iQQBot
Copy link
Contributor Author

iQQBot commented Nov 27, 2024

Not sure I got this right: Are we using the old ws API? Or the gRPC-based, and would need a change here? Anyway, I think it would be great to keep both in sync if not too much effort.

@geropl I think we don't need update this one, because the grpc public API on server it's already per service per 200 times per minute, and supervisor will call grpc public API (golang version) and this grpc server will direct call websocket version API on server side.

@geropl
Copy link
Member

geropl commented Nov 27, 2024

I think we don't need update this one, because the grpc public API on server it's already per service per 200 times per minute, and supervisor will call grpc public API (golang version) and this grpc server will direct call websocket version API on server side.

💡 Ah, you are right - thank you!

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I am able to clone about 100 repos now just fine! 🎉

For bigger repos, this shouldn't be a problem, because fetching bigger repos will usually roll over to the next minute.

@iQQBot
Copy link
Contributor Author

iQQBot commented Nov 27, 2024

/unhold

@roboquat roboquat merged commit 490f507 into main Nov 27, 2024
73 of 74 checks passed
@roboquat roboquat deleted the pd/increate-get-token-rate-limit branch November 27, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants