Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to .NET 8 #1302

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Upgrade to .NET 8 #1302

wants to merge 5 commits into from

Conversation

ArinGhazarian
Copy link
Collaborator

  • Did you write/update appropriate tests
  • Release notes updated (if appropriate)
  • Appropriate logging output
  • Issue linked
  • Docs updated (or issue created)
  • New package licenses are added to ThirdPartyNotices.txt (if applicable)

Copy link

github-actions bot commented Nov 22, 2024

Unit Test Results

840 tests   840 ✅  21s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit baee7ac.

♻️ This comment has been updated with latest results.

Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
gei 81% 72% 584
ado2gh 84% 78% 631
Octoshift 87% 77% 1327
bbs2gh 79% 74% 692
Summary 84% (7081 / 8465) 75% (1648 / 2184) 3234

@ArinGhazarian
Copy link
Collaborator Author

ArinGhazarian commented Nov 22, 2024

The CI is green and INT tests are passing but the problem is that when running the INT tests, live console output is not getting logged (see below image). Need to investigate further but it could have been caused by trimming. I was also able to reproduce this locally.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant