C++: Generate int-to-bool conversion instructions in C code #18017
+608
−1,850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
force-pushed
the
generate-int-to-bool-conversion-instructions
branch
from
f47fd94
to
7e13550
Compare
MathiasVP
force-pushed
the
generate-int-to-bool-conversion-instructions
branch
from
7e13550
to
92ac5f6
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedExpr.qll
Fixed
Show fixed
Hide fixed
MathiasVP
force-pushed
the
generate-int-to-bool-conversion-instructions
branch
from
92ac5f6
to
2dc34c7
Compare
MathiasVP
changed the title
MathiasVP
force-pushed
the
generate-int-to-bool-conversion-instructions
branch
from
2dc34c7
to
c9b478b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the inconsistencies highlighted in #18013 by generating the IR for int-to-bool conversions as part of IR generation. There are three places where we need to do something (based on grep'ing for
Opcode::LogicalNotandOpcode::ConditionalBranch):NotExpr?:with two operandsCommit-by-commit review recommended.