Skip to content
This repository has been archived by the owner on Jun 14, 2020. It is now read-only.

Followup UI improvements #159

Open
lourot opened this issue Sep 26, 2018 · 2 comments
Open

Followup UI improvements #159

lourot opened this issue Sep 26, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@lourot
Copy link
Member

lourot commented Sep 26, 2018

After #158 I think we should

  1. remove 0 star badges
  2. remove/improve repetitive "explanations" like [small project] : this repo seems to be a small project

What do you think @brillout?

@lourot lourot added enhancement New feature or request good first issue Good for newcomers labels Sep 26, 2018
@brillout
Copy link
Collaborator

brillout commented Sep 26, 2018

  1. Personally I'd rather have a maximum amount of repos shown on a profile page. Kinda like the exhaustive thing we have. Actually I thought that we could add not-self-starred repos with one condition: It's not a fork of a repo that the user has contributed to. Why do you want to get rid of smaller contribs? Some of your 0-star contribs seem to be legit. Ahhh actually I'm thinking: Do you want to keep the contrib but only remove the badge?

  2. Agree. Actually already thought about this and was thinking that a tooltip like https://popper.js.org/ could be good enough? (Instead of title=) Then no need to re-explain in the expended section. Thoughts?

@lourot
Copy link
Member Author

lourot commented Sep 26, 2018

  1. your last sentence yes :) I want to keep the contrib but remove the green 0 star.
  2. I'm not sure if a popper.js-tooltip is really better than a title=-tooltip, no preference, and also I'm open to move explanations fully into tooltips (this is how it used to be before Improve Profile Pages #158). My point here was just about the sentence itself, which is only repeating the same words as the badge, so adding no information :)

@lourot lourot removed the assigned label Oct 28, 2018
@lourot lourot added the help wanted Extra attention is needed label Jan 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants