Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(profiling) implement edge detection on profiling tooltip #81445

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Nov 28, 2024

Implement edge detection on profiling tooltip.

We used to have no edge detection, meaning that tooltips could overflow the screen on x axis and become partially hidden. This change implements edge detection, ensuring the tooltip is always contained inside the container (body)

Video shows new vs previous behavior

CleanShot.2024-11-28.at.15.55.03.mp4

@JonasBa JonasBa requested review from a team as code owners November 28, 2024 20:59
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 28, 2024
@JonasBa JonasBa changed the title ref(profiling) optimize getBoundingClientRect ref(profiling) implement edge detection on profiling tooltip Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 14.81481% with 23 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
static/app/components/profiling/boundTooltip.tsx 16.00% 21 Missing ⚠️
static/app/utils/profiling/gl/utils.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #81445      +/-   ##
==========================================
+ Coverage   80.35%   80.37%   +0.01%     
==========================================
  Files        7232     7229       -3     
  Lines      320019   319624     -395     
  Branches    20823    20764      -59     
==========================================
- Hits       257155   256886     -269     
+ Misses      62470    62345     -125     
+ Partials      394      393       -1     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant