This repository has been archived by the owner on Nov 8, 2023. It is now read-only.
feat: Errors consumer polls producer #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds the ProducerError enum and raises MessageRejected if the producer queue is full.
fpacifici
reviewed
Jun 24, 2022
Comment on lines
+59
to
+61
| if let Err(ProducerError::QueueFull) = res { | ||
| return Err(ProcessingError::MessageRejected); | ||
| } |
There was a problem hiding this comment.
Do you plan to start using futures instead? The issue with this approach, I think, is that it puts you in a CPU tight loop while you wait for the message to be produced, while you can leave the CPU free by waiting on a fuiture.
There was a problem hiding this comment.
I think using futures might make more sense. But this is not actually a synchronous function currently and we are not waiting. It fires a delivery callback when it's done.
fpacifici
approved these changes
Jun 24, 2022
fpacifici
approved these changes
Jun 24, 2022
This reverts commit 3ef068d.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds the ProducerError enum and raises MessageRejected
if the producer queue is full.