Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining to-dos from SSO PR #976

Closed
8 tasks done
matthew-white opened this issue Sep 13, 2023 · 6 comments
Closed
8 tasks done

Remaining to-dos from SSO PR #976

matthew-white opened this issue Sep 13, 2023 · 6 comments
Assignees
Labels
refactor Improves code without altering behavior

Comments

@matthew-white
Copy link
Member

matthew-white commented Sep 13, 2023

The SSO PR #910 was merged earlier today. 🎉 This issue is to track comments and any other to-dos from the PR that are still open.

I'm going to copy some to-dos that @alxndrsn mentioned on Slack. @alxndrsn, please feel free to edit or add to the list below! CC also @sadiqkhoja: feel free to leave a comment if there are other to-dos from the PR.

If it'd be helpful, I also think that any of these to-dos could be split into separate issues.

Moving code around

More in-depth refactor

Tracked elsewhere

@matthew-white matthew-white added the refactor Improves code without altering behavior label Sep 13, 2023
@github-project-automation github-project-automation bot moved this to 🕒 backlog in ODK Central Sep 13, 2023
@matthew-white matthew-white moved this from 🕒 backlog to ✏️ in progress in ODK Central Sep 13, 2023
@matthew-white
Copy link
Member Author

I can make a note of this in #588, but I thought I'd mention that oidc-e2e-test failed once for me: https://github.com/getodk/central-backend/actions/runs/6218293098/attempts/1. When I reran it, it passed.

@alxndrsn
Copy link
Contributor

@matthew-white I've also seen these intermittent failures and in integration tests. I suspect an issue in the fake-oidc-server, but we can't currently see the logs. I'll see if it's simple to add the logs to the github actions.

@alxndrsn
Copy link
Contributor

@matthew-white actually the logs seem to be available already.

From the failure screenshot on your job, it looks like playwright/webkit interaction failure:

test-failed-1

It's clear the password has ended up in the wrong input field.

@alxndrsn
Copy link
Contributor

There's a very similar bug filed at microsoft/playwright#26349, but without much detail.

@alxndrsn
Copy link
Contributor

@matthew-white the other option is to enable retries for the playwright tests. Less red builds, but also it will mask real problems 🤷

@matthew-white matthew-white moved this from ✏️ in progress to 🕒 backlog in ODK Central Sep 27, 2024
@alxndrsn
Copy link
Contributor

alxndrsn commented Oct 15, 2024

@github-project-automation github-project-automation bot moved this from 🕒 backlog to ✅ done in ODK Central Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Improves code without altering behavior
Projects
None yet
Development

No branches or pull requests

2 participants