Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OIDC login fails due to Authentik sending state QS and node-openid-client failing a check #1134

Open
openbrian opened this issue May 1, 2024 · 0 comments · May be fixed by #1135
Open

OIDC login fails due to Authentik sending state QS and node-openid-client failing a check #1134

openbrian opened this issue May 1, 2024 · 0 comments · May be fixed by #1135

Comments

@openbrian
Copy link

It's all here. https://forum.getodk.org/t/oidc-issue-when-logging-in/46619
openbrian added a commit to openbrian/central-backend that referenced this issue May 1, 2024
@openbrian
improve: Also pass along a state (nonce) paramater.
06763fe 
bug: getodk#1134

It's not needed for CSRF protection because code_challenge does this, but the Authentik IDP will return &state= in the query string.  This will trigger node-openid-client to fail a check.
@openbrian openbrian linked a pull request May 1, 2024 that will close this issue
Open
2 tasks
openbrian added a commit to openbrian/central-backend that referenced this issue May 1, 2024
@openbrian
improve: Also pass along a state (nonce) paramater.
6776bab 
bug: getodk#1134

It's not needed for CSRF protection because code_challenge does this, but the Authentik IDP will return &state= in the query string.  This will trigger node-openid-client to fail a check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improve: Also pass along a state (nonce) paramater. openbrian/central-backend
1 participant
@openbrian