Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add Geo Arrow Icon Layer #123

Open
MMJ744 opened this issue Apr 17, 2024 · 2 comments
Open

Feature Request: Add Geo Arrow Icon Layer #123

MMJ744 opened this issue Apr 17, 2024 · 2 comments

Comments

@MMJ744
Copy link

MMJ744 commented Apr 17, 2024

Could you create a layer wrapper for the Icon Layer

I've been using the GeoArrowScatterplotLayer but wanted more control over what the rendered points look like, e.g shape.

I've taken a look at the source code for the layers but I can't quite figure out what would be different when wrapping the icon layer. Any chance of this layer being added, or more guidance on how I might be able to create/contribute it myself.

Thanks :)

@kylebarron
Copy link
Member

I think you included the wrong link.

In any case, it should largely be copy and paste from the ScatterplotLayer or PointCloudLayer (I'd probably point you to the PointCloudLayer for reference, because the IconLayer probably shouldn't support MultiPoint geometries), but you also need to include the extra parameters to pass the iconAtlas, iconMapping, etc to the upstream layer.

am2222 pushed a commit to am2222/deck.gl-layers that referenced this issue Jun 20, 2024
am2222 pushed a commit to am2222/deck.gl-layers that referenced this issue Jun 20, 2024
@am2222
Copy link

am2222 commented Jun 20, 2024

@kylebarron can you please have a look at this PR (#129)?

am2222 pushed a commit to am2222/deck.gl-layers that referenced this issue Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants