-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore adding the "complicated" (full provenance) GAF 2.2 header to the GPAD 2.0 #387
Comments
Tagging @sierra-moxon |
Talking to @pgaudet , @kltm will follow up with @sierra-moxon |
I think the ask here is to include the source file(s) headers in addition to the gpad-version, date-generated, and generated-by header values it already has. the source headers include (when available):
this will require two changes: one to the GpadWriter itself to accept a source param, and in validate.py (the script called from mega make step to produce GPAD). |
@sierra-moxon I'm happy to talk more about it, but the idea is to preserve as much of the provenance as we can in our output files, letting the final consumer know where things are coming from and giving them a better idea how to debug (this is our intent). Right now, the "best" example we have of this is the GAF headers. (They themselves have some issues, but are considered fine for now.) |
This is what the header looks like in my development branch for a test set, GOA-chicken
Does this seem reasonable and/or does it need any changes? I think its a bit strange to see the GAF bits in the GPAD header, but not quite sure. @kltm, @pgaudet |
@sierra-moxon I think this looks good to me? WRT seeing the GAF header: technically, these files are being derived from GAF (source GAF file), so I think that's fine. Moreover, the GPAD is more "internal" anyways. |
Looks good! thanks @sierra-moxon ! |
Talking to @pgaudet , we were wondering if it would be possible to have the "complicated"/full provenance GAF 2.2 header also be emitted into the GPAD 2.0? While not technically a show-stopper, as the GPAD 2.0 is going to be a bit more of an "internal" format moving forward, it is nice to have and would be good to be consistent.
The text was updated successfully, but these errors were encountered: