Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'detection of light stimulus involved in visual perception' should not be SubClassOf 'detection of visible light' #28657

Closed
dosumis opened this issue Aug 2, 2024 · 5 comments
Assignees

Comments

@dosumis
Copy link
Contributor

dosumis commented Aug 2, 2024

I think this is wrong and too human centric. Birds and insects with UV photoreceptors perceive images using those receptors. This is visual perception. This is causing problems for CL definition of photoreceptors. See obophenotype/cell-ontology#2253

@dosumis dosumis self-assigned this Aug 2, 2024
@dosumis
Copy link
Contributor Author

dosumis commented Aug 2, 2024

There are other superclasses, so it looks like this could just be deleted.

@dosumis dosumis closed this as completed in 68871a3 Aug 2, 2024
@dosumis
Copy link
Contributor Author

dosumis commented Aug 2, 2024

Ooops - I accidentally did a hot fix to master !! Sorry!!!

I didn't think that was possible on ODK repos. Should probably set github to block.

Anyway - I think minor edit so should be harmless. Would have like to look for any secondary effect though!

@cmungall
Copy link
Member

cmungall commented Aug 2, 2024 via email

@dosumis
Copy link
Contributor Author

dosumis commented Aug 2, 2024

I don't think any grouping classes need changing. While this does leave a singleton, there is definitely plenty of detection of visible light outside visual perception - e.g. in plants or by clock cells with cryptochromes

image

@dosumis
Copy link
Contributor Author

dosumis commented Aug 2, 2024

Passes QC at least
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants