A bunch of small fixes and improvements #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o 1.17 and use the unsafe.Slice function
…r the device data callback
|
I am not sure about that unsafe.Slice, is nice, and probably is safer but it is too early for that. Not even all CI systems got support for 1.17. I am for that change, but not since day one I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request:
Upgrades to Miniaudio v0.10.42
Makes Malgo a Go module
Uses unsafe.Slice to create slices pointing to C memory in the device data callback. Unsafe.Slice was introduced in Go 1.17, but we should really use it since it's likely more safe / reliable / understandable than what we were using.
Changes DeviceInfo.Name to not return a string with null bytes.
Fixes #28