-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor toolbar into an ipywidgets subclass #1664
Conversation
Hmm, I somehow managed to close the pull request. I am still learning how to work with GitHub. Will see if I can recover this PR post merge or if I need to create a new one. |
There is, but it is disabled and says "There are no new commits on the bengalin:widgets branch". So I guess the commits I have locally are no longer on my remote branch. And locally,
|
You might have accidentially overwrite your local branch with the remote master branch. I can no longer see your commits |
Okay, I managed to fetch and merge locally, and then after some magic the reopen PR button was active again. So I think we are good? |
This is really well done! I tested it and everything works fine. I really like the refactoring. Much more elegant than my previous version. Learned some new tricks from your code. Thank you very much for your contribution! |
Created a new dataclass,
Toolbar.Item
, that defines an entry in the Toolbar.Once
layer_manager_gui()
is widgetized, we can move the new Toolbar widget intomap_widgets.py
. The code remaining intoolbar.py
will become simpler as the view and control separate.Future work can also include implementing
plotly_toolbar
the same way.Note that I uncommented the implementations for the help and gee tool items. If they are not needed, we can remove them (I think it is better to remove than to keep commented out code)