Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GMSH] Finish porting meshing #417

Open
1 of 6 tasks
simbilod opened this issue Jun 9, 2024 · 3 comments
Open
1 of 6 tasks

[GMSH] Finish porting meshing #417

simbilod opened this issue Jun 9, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@simbilod
Copy link
Collaborator

simbilod commented Jun 9, 2024

Tests are now passing and meshes generated, but some things still need to be ported better

  • don't hardcode the database unit when converting KLayout polygons to shapely for passing into meshwell
  • consider doing the polygon preprocessing in KLayout instead of shapely (only convert to shapely when interfacing with meshwell)
  • fix edge ports
  • fix get_component_with_net_layers
  • figure out issues with meshbool and physical overrides not being default=None
  • fix warnings
@simbilod simbilod added the enhancement New feature or request label Jun 9, 2024
@simbilod simbilod changed the title Finish porting meshing [GMSH] Finish porting meshing Jun 9, 2024
@simbilod
Copy link
Collaborator Author

get_component_with_net_layers fixed in #469 , thanks @mdecea

@joamatab
Copy link
Contributor

any updates on this Simon?

@simbilod
Copy link
Collaborator Author

The code gives good outputs, fixing these is not high priority right now. Feel free to close. Happy to give pointers to whoever would want to pick this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants