Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Easy-fix] Bad MouseWheel event context makes markers disrupt wheel events #32

Open
GoogleCodeExporter opened this issue Aug 3, 2015 · 1 comment

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Open the WebGL earth Markers.html example
2. Try to scroll-zoom the globe while hovering on a marker
3. Quietly weep.

What is the expected output? What do you see instead?
Markers shouldn't prevent mousewheel zooming.

Please provide any additional information below.
we/ui/mousezoomer.js line 78 
(https://github.com/webglearth/webglearth/blob/master/we/ui/mousezoomer.js#L78)
Event context should be containing div and not canvas because markers in 
overlay divs are disrupting mouse events.

Original issue reported on code.google.com by [email protected] on 30 Nov 2012 at 1:34

@GoogleCodeExporter
Copy link
Author

On a side note, adding event callbacks in the JS API would be a good idea.

Like:
    var earth = new WebGLEarth('earth_div', options);
    earth.onZoom(function(zoomLevel){
        // do something
    });

Thanks for reading.

Original comment by [email protected] on 30 Nov 2012 at 1:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant