Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardware support tags #122

Closed
avivace opened this issue Jan 21, 2022 · 3 comments
Closed

Hardware support tags #122

avivace opened this issue Jan 21, 2022 · 3 comments

Comments

@avivace
Copy link
Member

avivace commented Jan 21, 2022

Add tags exposing the support of the entry for particular hardware. See #121 for an example of homebrew making use of GB Camera.

I already added gbprinter..

  • What else could be added there? GB Camera?
  • Should those tags be "classified" as "hardware-support" ones so they can be filtered better?
@reini1305
Copy link
Contributor

Could you add the gbprinter tag also to game-schema-d3.json? scripts/validate.py uses that to check the schema against all game.jsons

@avivace
Copy link
Member Author

avivace commented Jan 21, 2022

Could you add the gbprinter tag also to game-schema-d3.json? scripts/validate.py uses that to check the schema against all game.jsons

The draft3 should remain frozen as we are introducing breaking changes with draft4. I'll update the scripts to start using the draft4 as json schema.

@dag7dev
Copy link
Contributor

dag7dev commented Jan 23, 2022

gbprinter and gbcamera should be enough. In GBA would be useful tilt for games that uses tilt function and e-reader too.

What about additional-hardware-support instead of a generic hardware-support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants