Forward port humble->iron #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes an incorrect subscription on one of the demos. Running ``` ros2 launch ros_gz_sim_demos gpu_lidar_bridge.launch.py ``` causes rviz2 to crash and exit with the error: ``` rviz2-3] [rviz2-3] >>> [rcutils|error_handling.c:108] rcutils_set_error_state() [rviz2-3] This error state is being overwritten: [rviz2-3] [rviz2-3] 'create_subscription() called for existing topic name rt/lidar with incompatible type sensor_msgs::msg::dds_::PointCloud2_, at ./src/subscription.cpp:146, at ./src/rcl/subscription.c:108' [rviz2-3] [rviz2-3] with this new error message: [rviz2-3] [rviz2-3] 'invalid allocator, at ./src/rcl/subscription.c:218' [rviz2-3] [rviz2-3] rcutils_reset_error() should be called after error handling to avoid this. ``` This is due to an incorrect subscription on the part of the demo. This PR fixes it by getting a subscription to the right topic for the pointcloud display. (`lidar/points` instead of `lidar`). Was tested on garden + humble. Signed-off-by: Arjo Chakravarty <[email protected]>
The ROS type for gz.msgs.NavSat messages should be **sensor_msgs/msg/NavSatFix** instead of **sensor_msgs/msg/NavSatFixed** Signed-off-by: Arjun K Haridas <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
[backport Humble] Added more topic to the bridge (#422)
[backport humble] Update README.md (#411)
Signed-off-by: Aditya Pande <[email protected]> Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Aditya Pande <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Aditya Pande <[email protected]>
[backport humble] SensorNoise msg bridging (#417)
Signed-off-by: Addisu Z. Taddese <[email protected]>
[backport humble] Add link to project template (#428)
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Fix the branch name when checking out ros_gz otherwise `rosdep install -r --from-paths src -i -y --rosdistro humble` errors with incompatible versions. Additonally link to #401 (comment) which allows compilation on Ubuntu 20.04 + ROS2 Humble + Ignition Fortress Signed-off-by: Samuel Seng <[email protected]>
Signed-off-by: ymd-stella <[email protected]> Co-authored-by: ymd-stella <[email protected]>
Signed-off-by: Michael Anderson <[email protected]> Co-authored-by: andermi <[email protected]>
Signed-off-by: wittenator <[email protected]>
* Add harmonic CI (#447) * Add harmonic CI Signed-off-by: Michael Carroll <[email protected]> * Include garden options Signed-off-by: Michael Carroll <[email protected]> * Add harmonic stanza Signed-off-by: Michael Carroll <[email protected]> * Additional message headers Signed-off-by: Michael Carroll <[email protected]> --------- Signed-off-by: Michael Carroll <[email protected]> * Use stable osrf repo for Garden and stable+prerelease for Harmonic (#448) Harmonic is now in the prerelease repository Signed-off-by: Jose Luis Rivero <[email protected]> * Add additional cmake/package.xml changes * Update headers * Update namespaces * Add ci for harmonic/humble * Update readme --------- Signed-off-by: Michael Carroll <[email protected]> Signed-off-by: Jose Luis Rivero <[email protected]> Signed-off-by: Addisu Z. Taddese <[email protected]> Co-authored-by: Michael Carroll <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]>
We do a little of both in this one because gazebo does forward ports and ros does backports. It can be a bit muddled, but it works. |
mjcarroll
reviewed
Dec 5, 2023
Signed-off-by: Addisu Z. Taddese <[email protected]>
azeey
force-pushed
the
azeey/fwd_humble
branch
from
0f12572
to
1205938
Compare
mjcarroll
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port humble to iron
Not sure if we do forward ports in this repo, but I thought it was the best way to get the changes from #461, #458, and potentially other changes into
iron.Question:
Changelogfiles that I removed. Should I include them? Same for version changes inpackage.xmlwhere the merge brought in 0.247.Branch comparison: iron...humble
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸