Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on_exit_shutdown is not evaluated correctly #494

Closed
azeey opened this issue Feb 7, 2024 · 1 comment
Closed

on_exit_shutdown is not evaluated correctly #494

azeey opened this issue Feb 7, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@azeey
Copy link
Contributor

azeey commented Feb 7, 2024

Environment

  • OS Version: Ubuntu 22.04
  • Source or binary build? 2dca358

Description

  • Expected behavior: Setting on_exit_shutdown launch argument to false to work properly
  • Actual behavior: on_exit_shutdown is a str when evaluated in the if statement below:
    if on_exit_shutdown:

This means setting it to 'true' or 'false' will always be treated as True. Perhaps we can use IfCondition and call evaluate here instead?

@azeey azeey added the bug Something isn't working label Feb 7, 2024
@azeey azeey moved this from Inbox to To do in Core development Feb 28, 2024
@Amronos
Copy link
Contributor

Amronos commented Oct 18, 2024

This has been fixed in #617.

@azeey azeey closed this as completed Oct 18, 2024
@github-project-automation github-project-automation bot moved this from To do to Done in Core development Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants