Use spdlog_vendor in package.xml

[azeey]

🦟 Bug fix

Summary

spdlog is not being properly found on ROS windows builds. Example: https://ci.ros2.org/view/nightly/job/nightly_win_rel/3158/cmake/new/

Per @clalancette's recommendation, this patch changes the package.xml entry to spdlog_vendor.

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[clalancette]

So I don't think that this is going to be the correct fix in general.

That is, here in gz-utils, there is no guarantee that you have a ROS environment available, and hence spdlog_vendor.

Instead, I think you need to put a fix into https://github.com/gazebo-release/gz_utils_vendor . There, you'll need to add in a package.xml dependency on both spdlog and spdlog_vendor, and also make sure to find_package(spdlog_vendor REQUIRED) to make sure that the CMake paths are setup. You can take a look at https://github.com/ros2/rcl_logging/tree/rolling/rcl_logging_spdlog for an example of what I think you should do.

[azeey]

Yup, you're right. This should be done in gz_utils_vendor. I've updated the generation script gazebo-tooling/gz_vendor#9 and I've approved gazebo-release/gz_utils_vendor#6