Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uncontrolled cast of size_t to uint #2687

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

j-rivero
Copy link
Contributor

🦟 Bug fix

Remove warning existing in Conda Windows builds. See https://build.osrfoundation.org/view/conda/job/gz_sim-ign-gazebo6-cwin/1/msbuild/

Summary

Fix the warning:

'argument': conversion from 'size_t' to 'unsigned int', possible loss of data (compiling source file C:\J\workspace\gz_sim-ign-gazebo6-cwin\ws\gz-sim\src\SimulationRunner.cc)

by controlling the cast from site_t to unsigned int.

Fixed here: Build Status

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Nov 26, 2024
@j-rivero j-rivero merged commit 0d3af5b into ign-gazebo6 Nov 27, 2024
10 checks passed
@j-rivero j-rivero deleted the jrivero/fix_warn_on_runner branch November 27, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants