-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumps in ionic: gz-plugin3 #127
Conversation
Signed-off-by: Addisu Z. Taddese <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to update the logic for setting GZ_TOOLS_VER
at CMakeLists.txt:48
…mp_ionic_gz-plugin3 Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Merged #119 that took care of this. |
Codecov Report
@@ Coverage Diff @@
## main #127 +/- ##
==========================================
+ Coverage 98.26% 98.72% +0.46%
==========================================
Files 23 23
Lines 748 785 +37
==========================================
+ Hits 735 775 +40
+ Misses 13 10 -3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor comment about unintended changes in test but they should be harmless
Signed-off-by: Addisu Z. Taddese <[email protected]>
See gazebo-tooling/release-tools#1027