Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bullet-featherstone: Parse voxel resolution SDF param when decomposing meshes #655

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jun 14, 2024

🎉 New feature

Summary

Makes use of the voxel resolution SDF param added in gazebosim/sdformat#1429.

see screenshot of a mesh with different voxel resolutions in gazebosim/gz-sim#2445

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.26%. Comparing base (92e02c3) to head (02e6738).
Report is 20 commits behind head on gz-physics7.

Additional details and impacted files
@@               Coverage Diff               @@
##           gz-physics7     #655      +/-   ##
===============================================
+ Coverage        78.32%   79.26%   +0.93%     
===============================================
  Files              140      141       +1     
  Lines             8069     8274     +205     
===============================================
+ Hits              6320     6558     +238     
+ Misses            1749     1716      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iche033 iche033 merged commit a1cb989 into gz-physics7 Jun 17, 2024
11 checks passed
@iche033 iche033 deleted the voxel_resolution branch June 17, 2024 16:16
@iche033 iche033 added the Bullet Bullet engine label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bullet Bullet engine 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants