First pass at level1 clazy checks for qt #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
mjcarroll/implptr
branch
2 times, most recently
from
b84c93f
to
20bf135
Compare
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
mjcarroll/implptr
branch
from
20bf135
to
ed63b7b
Compare
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
mjcarroll/clazy
branch
from
de5ef68
to
2052269
Compare
Signed-off-by: Michael Carroll <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
==========================================
+ Coverage 70.05% 70.14% +0.09%
==========================================
Files 38 38
Lines 5356 5343 -13
==========================================
- Hits 3752 3748 -4
+ Misses 1604 1595 -9 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Michael Carroll <[email protected]>
jennuine
approved these changes
Nov 13, 2023
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up
clazywarnings to make sure we are using Qt correctly.