-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix plugin filter on Windows #567
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Pecka <[email protected]>
2 tasks
traversaro
reviewed
Sep 3, 2023
Co-authored-by: Silvio Traversaro <[email protected]> Signed-off-by: Martin Pecka <[email protected]>
peci1
force-pushed
the
fix-plugin-filter-win
branch
from
September 4, 2023 06:23
d5f2da9
to
937583c
Compare
Signed-off-by: Martin Pecka <[email protected]>
Codecov Report
@@ Coverage Diff @@
## gz-gui8 #567 +/- ##
===========================================
- Coverage 70.06% 68.11% -1.96%
===========================================
Files 39 39
Lines 5359 5375 +16
===========================================
- Hits 3755 3661 -94
- Misses 1604 1714 +110
|
traversaro
reviewed
Sep 4, 2023
Co-authored-by: Silvio Traversaro <[email protected]> Signed-off-by: Martin Pecka <[email protected]>
iche033
reviewed
Sep 5, 2023
Co-authored-by: Ian Chen <[email protected]> Signed-off-by: Martin Pecka <[email protected]>
iche033
approved these changes
Sep 18, 2023
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Martin Pecka <[email protected]>
traversaro
approved these changes
Oct 25, 2023
@osrf-jenkins retest this please |
mjcarroll
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
On Windows, the plugin combobox in GUI was always empty (both in GUI alone and in GZ GUI). This PR fixes it.
It seems to me it 'd be beneficial if this logic was extracted as helper functions to gz-plugin.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.