ros_gz documentation updates #508
Conversation
…ther ros_gz tutorials and note about the functionality only available in Rolling. Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
harmonic/ros2_spawn_model.md
Outdated
| @@ -43,9 +43,9 @@ within this tag. Here's an example: | |||
| <gz_spawn_model | |||
| world="$(var world)" | |||
| file="$(var file)" | |||
| xml_string="$(var xml_string)" | |||
| world_string="$(var world_string)" | |||
There was a problem hiding this comment.
I just realized this change was merged recently, but I don't think it makes sense to call this world_string since this is being used to spawn a model. Mind changing this to model_string here and in ros_gz?
There was a problem hiding this comment.
Updated in ab674e3 and gazebosim/ros_gz#605
Signed-off-by: Carlos Agüero <[email protected]>
I mentioned it here. https://github.com/gazebosim/docs/pull/508/files#diff-85712e72cdaaf1dc8adface4ae8ab48e71e322457abf1d334f665ddd387dbb20R29-R30 Do you think that's enough? |
Sure, I'm about to create another PR with another Python example. We can trigger the release afterwards if that's OK. |
|
Great! |
🦟 Bug fix
Documentation updates including updated bridge parameters, links to other ros_gz tutorials and a note about the functionality only available in Rolling.
Summary
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.