Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ign -> gz: gz debs for Citadel and Fortress #788

Closed
29 tasks done
Tracked by #698
chapulina opened this issue Aug 10, 2022 · 6 comments
Closed
29 tasks done
Tracked by #698

ign -> gz: gz debs for Citadel and Fortress #788

chapulina opened this issue Aug 10, 2022 · 6 comments
Assignees
Labels
ign to gz Renaming Ignition to Gazebo.

Comments

@chapulina
Copy link
Contributor

chapulina commented Aug 10, 2022

Add gz wrapper packages for each ignition one.

Citadel

Fortress

@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Aug 10, 2022
@chapulina chapulina self-assigned this Aug 10, 2022
@chapulina
Copy link
Contributor Author

@j-rivero , I'd appreciate some feedback on gazebo-release/gz-cmake2-release#5 before I open the remaining PRs. I'm using the same approach that we did to add ignition wrappers for gz on Garden (#736).

I changed the Section from oldlibs to metapackages because that seemed to apply better for this use case to me. References:

@chapulina
Copy link
Contributor Author

Humm lintian didn't like me using metapackages:

W: libgz-cmake2-dev: transitional-package-should-be-oldlibs-optional metapackages/optional

https://build.osrfoundation.org/job/ign-cmake2-debbuilder/1656/consoleFull

Reading about transitional packages, I think I'm violating some best practices. Not sure that's the way to go in this case.

https://wiki.debian.org/RenamingPackages

I think what I'm trying to do here is adding a package alias, but a quick search didn't give me any hints on how to do that.

@j-rivero , what do you suggest we do here? Should we do the same that was done for Garden? I guess that wouldn't break anyone, so it's backwards compatible.

@j-rivero
Copy link
Contributor

I'm proposing a change in gazebo-release/gz-cmake2-release#5 (comment) that could simplify the views about this "alias" and the Section metadata.

@chapulina
Copy link
Contributor Author

Testing the libgz debs now, I realized that we should have forced them to pull the same version of the libignition one with (= ${binary:Version}), as in:

Package: libgz-physics2-core-dev
Depends: libignition-physics2-core-dev (= ${binary:Version}), ${misc:Depends}

That's also true for the Garden libignition wrappers around libgz (#736). I'll make sure to do this for all the remaining releases, and to set it up for the rest, but I won't retrigger all the releases again, so the updates will come when a regular release is done for other reasons.

@scpeters
Copy link
Contributor

I think it's due to a cmake warning

CMake Warning at /usr/share/cmake/ignition-cmake2/cmake2/IgnConfigureBuild.cmake:55 (message):
   CONFIGURATION WARNINGS:
   -- Skipping component [optix]: Missing dependency [OptiX].
      ^~~~~ Set SKIP_optix=true in cmake to suppress this warning.

https://build.osrfoundation.org/job/ign-rendering3-debbuilder/100/consoleFull#console-section-8

need to backport gazebo-release/gz-rendering6-release#7

@chapulina
Copy link
Contributor Author

I think it's due to a cmake warning

Ah easy! Thanks for catching that. I'll do the backport and trigger a new release to go 🟢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ign to gz Renaming Ignition to Gazebo.
Projects
None yet
Development

No branches or pull requests

3 participants