Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ign to gz : release-tools and build scripts #745

Open
Tracked by #698
methylDragon opened this issue Jun 16, 2022 · 0 comments
Open
Tracked by #698

ign to gz : release-tools and build scripts #745

methylDragon opened this issue Jun 16, 2022 · 0 comments
Labels
ign to gz Renaming Ignition to Gazebo.

Comments

@methylDragon
Copy link
Contributor

methylDragon commented Jun 16, 2022

See: #698

There is a lot to change in the release-tools repo, and it's complicated by the fact that there are multiple things to juggle that look similar, but aren't necessarily related or co-migrateable:

  • CMake project names (e.g. ignition-gazebo7)
  • CMake generated library targets (e.g. libignition-gazebo7-...)
  • GitHub branch names (e.g. ign-gazebo6)
  • Generated debian packages (e.g. libignition-cmake2-dev)
  • Jenkins job names
  • and more that I probably didn't manage to hit..

This makes it exceptionally difficult, since the similar looking names makes it hard to trace what refers to what, and there's also a possibility where names are shared/coupled by bash variables flying all around the scripts in this repo.

Also, it's ambiguous whether gazebo means Gazebo Classic, or Gazebo... (e.g. gazebo-base-default.bash)


This is a tracking issue to keep track of (non-exhaustive) list of the things that can/need to be migrated, and where they occur:

  • Links to github repos
  • sed rules for bumping stuff in homebrew-simulation (bump_dependency.bash)
  • DSL filenames (e.g. ignition_collection.dsl)
  • jenkins script names (e.g. ign_cmake-default-devel-windows-amd64.bat)
  • ABI_JOB_SOFTWARE_NAME, which takes information from variables in this file
    • It has conditional logic that appears in places like ignition-abichecker.bash that checks for equality with ign- prefixed names
    • This one is complicated because those names target branches, so naively changing gazebo to sim won't work
  • ignition arguments and variables in release-bloom.py
  • Dependency names in _generic_linux_compilation_build.sh.bash (e.g. IGN_CMAKE, which bubbles down to BUILD_IGN_XXX variables used elsewhere)

Because of how many items there are to migrate, let's split it up into several PRs:

@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ign to gz Renaming Ignition to Gazebo.
Projects
None yet
Development

No branches or pull requests

2 participants