Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What should Raptor do about assets? #34

Open
garybernhardt opened this issue Feb 18, 2012 · 8 comments
Open

What should Raptor do about assets? #34

garybernhardt opened this issue Feb 18, 2012 · 8 comments

Comments

@garybernhardt
Copy link
Owner

Tom, when you asked "Should raptor include asset serving itself?", are you asking about simply serving a public directory, or are you asking about fancy asset pipeline stuff like the changes in Rails 3 that I don't understand?

@tcrayford
Copy link
Collaborator

Yes

Both of those (but seperately)

@garybernhardt
Copy link
Owner Author

What do Sinatra folks do?

@tcrayford
Copy link
Collaborator

Often times (from what I can see in their docs, and from experience), they'll write an action of their own that directly serves assets (and e.g. compiles coffeescript on the fly) for development mode. By default, sinatra just serves all files under /public by default.

I think serving stuff out of public is good enough for me for now (I can compile sass by myself)

@tcrayford
Copy link
Collaborator

Looking at sinatra's source code, they inlined the static serving into the framework (probably for speed).

@garybernhardt
Copy link
Owner Author

I think that's a reasonable thing to do: mount some Rack app to serve static content.

@tcrayford
Copy link
Collaborator

In raptor right? I can probably send a pull request soon.

@psyho
Copy link

psyho commented Feb 21, 2012

how about Rack::Static? Isn't that good enough?

@tcrayford
Copy link
Collaborator

We probably want Rack::File instead of Static, at least as I see it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants