-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for simulating synthetic lightcurves and fitting the PSD of an observed curve. #29
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thanks a lot @cgalelli ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cgalelli . This looks good to me. It would be simpler if some of the code could be imported for SyLC indeed. We can keep that for later though.
The gammapy version is defined in the env.yml. Maybe a Regarding names, we have not done it yet, but we could/should. What would be the proposal for that? How does additional changes (maintenance, upgrades) is taken into account? |
I finally could solve the problem with the import of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cgalelli . There seems to be a problem with the notebook. It is not recognized as such in the CI. Could you check if there is a problem? Is the very long name a good idea?
…d fitting the power spectral density of a lightcurve.ipynb
Thanks @registerrier , indeed i had made a bit of a mess in the restructuring of the notebook. Now it should be fine. I had also used an old local name for the notebook that was quite long and cumbersome - returned to the name I had in the first commit. The CI I think will still fail due to the import of |
Co-authored-by: Régis Terrier <[email protected]>
Apparently it does not: i am trying to find an alternative way of installing the package in the environment file. |
This PR adds a recipe which implements some functions to generate synthetic lightcurves, nominally:
It also adds the function to create envelopes of the periodogram for a lightcurve, and a fitting function for the PSD of an observed curve. These function can also be found in the small package gammapy_SyLC that will probably be adapted to be used here in the future, once problems with installation are resolved.